Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upExplore enabling `large-tables` and/or `huge-tables` by default #1241
Comments
weiznich
added
discussion desired
help wanted
labels
Nov 7, 2017
sgrif
added this to the 1.2 milestone
Jan 15, 2018
This comment has been minimized.
sgrif
closed this
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedOct 6, 2017
I was looking at the compile times for our test suite with various table size features enabled, both when Diesel needed to be compiled, and when only the tests needed to be compiled. This was done on
rustc 1.22.0-nightly (325ba23d5 2017-09-19), with incremental comp enabled.It looks like these features no longer have any effect on application compilation time, and the
large-tablesfeature might have a small enough effect on the crate's compile time to be worth turning on by default.huge-tablesstill looks like it doubles our compilation time, but given that most users don't recompile Diesel often, maybe it's worth just enabling that by default, too. I want to explore this more on stable and without incremental comp.