/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`pg::types::Array` should implement `SqlOrd` #1339

Closed
sgrif opened this Issue Dec 2, 2017 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  1.1
3 participants
@sgrif @virome @killercup
@sgrif
Member

sgrif commented Dec 2, 2017

Turns out that MAX(int[]) totally works. This is a trivial thing to fix, but I don't want us to start adding a ton of new features until after 1.0 is out. This needs to wait for 1.1.

@sgrif sgrif added the good first issue label Dec 2, 2017

@sgrif sgrif added this to the 1.1 milestone Dec 3, 2017

@virome

This comment has been minimized.

Sign in to view
Contributor

virome commented Jan 3, 2018

With 1.0 released, I'd like to take a stab at this one.

@killercup killercup added the assigned label Jan 3, 2018

@killercup

This comment has been minimized.

Sign in to view
Member

killercup commented Jan 3, 2018

Go for it, @virome!

@virome virome referenced this issue Jan 4, 2018

Merged

Impl sqlord for array #1449

@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jan 14, 2018

This was fixed by #1449

@sgrif sgrif closed this Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment