New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things that the initial SQLite PR will not handle but need to be fixed #134

Closed
sgrif opened this Issue Jan 24, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@sgrif
Member

sgrif commented Jan 24, 2016

  • Anything that invokes as_query on a command is a syntax error, as SQLite has no returning clause. We need to make AsQuery generic over the backend and not implement it for SQLite.
  • CLI is tightly coupled to PG. We need to not only support Sqlite but also figure out how to make this pluggable by third party crates that want to add additional adapters. Worst case this is a single line in our code and a #[cfg] attr for every third party crate that asks.
  • Codegen is tightly coupled to PG. We need to not only support Sqlite but also figure out how to make this pluggable by third party crates that want to add additional adapters. Worst case this is a single line in our code and a #[cfg] attr for every third party crate that asks.
  • Support for date, time, and timestamp
  • Support for numeric Numeric is not distinguishable from double on SQLite.
  • Support for IN statements. Unlike eq(any(array)), this will cause unbounded growth of prepared statements so we need to be careful.
@sgrif

This comment has been minimized.

Member

sgrif commented Dec 10, 2016

Everything here has been done except #184

@sgrif sgrif closed this Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment