New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`BINARY` should be a supported type name on SQLite #1355

Closed
sgrif opened this Issue Dec 6, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@sgrif
Member

sgrif commented Dec 6, 2017

It'd be given the NUMERIC affinity by SQLite, but I don't think that's relevant. The relevant code for this lives here

@kregoslup

This comment has been minimized.

kregoslup commented Dec 10, 2017

I would like to work on that issue, although I think I need some guidance. I'm not sure what do you mean by binary type name. I checked with SQLite reference here https://www.sqlite.org/datatype3.html point 3.1.1 and there is no binary type except for BLOB. Did you mean binary collating sequences?

@MarcManiez

This comment has been minimized.

Contributor

MarcManiez commented Jan 1, 2018

It's been a while since this there hasn't been activity on this issue so I went and submitted a PR for it. I hope that's ok, @kregoslup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment