/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`#[derive(QueryableByName)]` fails to compile if there is a type called `Result` in scope #1372

Closed
sgrif opened this Issue Dec 12, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@sgrif @Eijebong @MarcManiez
@sgrif
Member

sgrif commented Dec 12, 2017

I really wish people wouldn't shadow types from Rust's prelude, but we should probably explicitly reference std::result::Result
@Eijebong

This comment has been minimized.

Sign in to view
Member

Eijebong commented Dec 12, 2017

Very similar to #1354

@Eijebong Eijebong added the good first issue label Dec 12, 2017

theduke added a commit to theduke/diesel that referenced this issue Dec 12, 2017

@theduke
(derive) Use absolute path to Result in QueryableByName derive 
This prevents name collisions when a custom Result type is in scope.

Fixes diesel-rs#1372
e87a3d4

@theduke theduke referenced this issue Dec 12, 2017

Closed

(derive) Use absolute path to Result in QueryableByName derive #1379

This was referenced Dec 19, 2017

Closed
Merged
@MarcManiez

This comment has been minimized.

Sign in to view
Contributor

MarcManiez commented Jan 1, 2018

This conversation is very thoughtful. I believe this issue has been addressed in 443f43a and can be closed 🙂 .

@Eijebong Eijebong closed this Jan 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment