New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest diesel_codegen on crates.io requires syntex 0.25.*, while README says 0.26.* #138

Closed
Drakulix opened this Issue Jan 26, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Drakulix

Drakulix commented Jan 26, 2016

Basically what the title says. Crates.io version of diesel_codegen still requires syntex 0.25.* although the Readme clearly suggests to use ^0.26.0.
Git Repo seems to use 0.26.0 already, but was not pushed.

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 26, 2016

The README on master documents the code on master. You can find the older versions on the tag for that version. The latest released is at https://github.com/sgrif/diesel/tree/v0.4.1

@sgrif sgrif closed this Jan 26, 2016

@Drakulix

This comment has been minimized.

Drakulix commented Jan 26, 2016

Thanks for clarifying.

I would argue then, that master then should also track master in the README:
diesel_codegen = { git = "https://github.com/sgrif/diesel" }

The current Readme is confusing, because the most obvious example is broken.

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 27, 2016

We usually try to keep master correct for the upcoming release, as it's
difficult as maintainers to keep track of all of the things that we would
need to change when we actually make the release. I understand your
frustration, but usually these sorts of cases are rare and minor. The
difficulty of avoiding it as a maintainer would be more difficult. If you'd
like to put a note in the readme, with a link to the latest released
version, I would accept that PR.

On Tue, Jan 26, 2016 at 6:38 PM, Victor Brekenfeld <notifications@github.com

wrote:

I would argue, that master then should also track master in the README:
diesel_codegen = { git = "https://github.com/sgrif/diesel" }

This way is confusing and unintuitive, although understandable, as the
obvious example is broken.


Reply to this email directly or view it on GitHub
#138 (comment).

Thanks,
Sean Griffin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment