New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a file called `.keep` instead of `.gitkeep`. #1399

Open
sanmai-NL opened this Issue Dec 15, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@sanmai-NL

sanmai-NL commented Dec 15, 2017

diesel migration generate

creates a .gitkeep as well. Do not do this if the crate isn’t under Git VCS.

@sgrif

This comment has been minimized.

Member

sgrif commented Dec 16, 2017

I guess we can call the file .keep.

@sgrif sgrif changed the title from [1.0.0-beta1] Do not create `.gitkeep` outside of Git repo to Generate a file called `.keep` instead of `.gitkeep`. Dec 16, 2017

@ocamlmycaml

This comment has been minimized.

ocamlmycaml commented Oct 3, 2018

I’d like to take a stab at this issue. This would be my first rust project contribution here so i’m hoping this will be ok for that as well

@joelgallant

This comment has been minimized.

joelgallant commented Oct 5, 2018

If this was changed, could it also remove the old .gitkeep file?

@ocamlmycaml

This comment has been minimized.

ocamlmycaml commented Oct 6, 2018

If this was changed, could it also remove the old .gitkeep file?

hmm is that a good idea? it'll be dead code after you use diesel_cli once (in the newer release). I guess it's ok if I can add a TODO or issue to clean it up in a much later release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment