Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGet core working on stable and beta #14
Comments
sgrif
added
the
good first issue
label
Nov 28, 2015
sgrif
added this to the 0.1 milestone
Nov 28, 2015
This comment has been minimized.
|
These look to be the PRs that added support for |
This comment has been minimized.
|
@sgrif How do we get around the orphan rule here? Implementing
Sorry if this is a super noob question, I've still got my Rust training wheels on |
This comment has been minimized.
|
We shouldn't implement |
mfpiccolo
referenced this issue
Nov 28, 2015
Merged
Add times fn to allow tests to build on stable and beta #25
sgrif
closed this
in
#25
Nov 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedNov 28, 2015
This does not include the codegen or integration test crates. This issue is tracking the fact that core only builds on nightly. This is due to the fact that the way I implemented the interval DSL requires
From<i32>. I've implemented the interval dsl fori64andf64, which only implementFrom<i32>on nightly. We just need to copy paste the defaulted methods. Should be straight forward.The litmus test for this issue is the
yaqbdirectory passingcargo teston stable. codegen andyaqb_testsdo not need to pass on stable.