New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations do not give sufficient information about error cases #145

Closed
sgrif opened this Issue Jan 30, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@sgrif
Member

sgrif commented Jan 30, 2016

I'm unsure if we ever actually expect migration failures to be handled. Perhaps we should actually be unwraping from these functions. If not, we need to make sure our errors have sufficient information to be useful without a stacktrace, and not: QueryError(DatabaseError("near \"(\": syntax error"))

@sgrif

This comment has been minimized.

Member

sgrif commented Dec 16, 2017

Today our output looks like this:

screen shot 2017-12-16 at 12 26 02 pm

We should be able to assume that errors will only occur because of a bad connection, or an error running a specific migration. It's clear in the output when a connection error occurred (though the output could be better here), and when an error occurs running a migration, it immediately follows the migration version. I'm not sure that there's much else we can do here.

@sgrif sgrif closed this Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment