New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for `#[derive(Associations)] #1484

Closed
weiznich opened this Issue Jan 16, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@weiznich
Contributor

weiznich commented Jan 16, 2018

While porting #[derive(Associations)] from the old macro_rules based derive to a normal procedural macro derive in #1468 we noticed that there are no tests for this derive.
We should definitively write some tests to check if everything works as assumed.

@weiznich weiznich added this to the 1.2 milestone Jan 16, 2018

@weiznich weiznich added the tests label Jan 16, 2018

@weiznich

This comment has been minimized.

Contributor

weiznich commented Jan 22, 2018

There are already tests in diesel_derives

@weiznich weiznich closed this Jan 22, 2018

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 23, 2018

They could stand to be a lot more exhaustive. For starters, there are no tests for having more than one association, using tuple structs, cases where the foreign key field is named differently than the foreign key column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment