/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need ToSql Cow to require T::Owned = ToSql? #1498

Closed
SoniEx2 opened this Issue Jan 19, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@SoniEx2 @sgrif
@SoniEx2

SoniEx2 commented Jan 19, 2018 •
edited

Problem Description

It seems redundant (and annoying) that T::Owned needs ToSql, especially considering that there isn't a blanket ToSql for Borrow types. Do we need this requirement?

Checklist

  • I have already looked over the issue tracker for similar issues.
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jan 19, 2018

Good point. No we don't.

@sgrif sgrif added the good first issue label Jan 19, 2018

@jbcden jbcden referenced this issue Jan 19, 2018

Merged

Remove ToSql impl for Cow #1499

@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jan 20, 2018

Fixed by #1499

@sgrif sgrif closed this Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment