/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit the expression module for PG specific expressions #153

Closed
sgrif opened this Issue Jan 31, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  0.5
1 participant
@sgrif
@sgrif
Member

sgrif commented Jan 31, 2016

Right now there's nothing to stop something like foo.is_distinct_from(bar) from compiling when used against SQLite. We need to audit our codebase for cases where something is PG specific, and make sure it only compiles for PG. We also need to look for cases where the syntax is different on SQLite. For example, SQLite has no NOW function, using the string literal 'now' instead.

@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016

@sgrif sgrif added the sqlite label Feb 3, 2016

@sgrif sgrif changed the title from [SQLite] Audit the expression module for PG specific expressions to Audit the expression module for PG specific expressions Feb 3, 2016

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Move PG specific expressions out of the global namespace 
We've also changed them to only compile when passed to a `PgConnection`,
and added tests to ensure this continues to be true. The
`WithQuerySource` is PG specific syntax, but interestingly, I didn't
have a good place to mark it as such. We've done a hacky workaround for
now.

Fixes #153
d71c186

@sgrif sgrif referenced this issue Feb 3, 2016

Merged

Move PG specific expressions out of the global namespace #188

@sgrif sgrif closed this in #188 Feb 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment