/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLite] Running our test suite spams the console with migration messages #156

Closed
sgrif opened this Issue Jan 31, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.5
2 participants
@sgrif @mfpiccolo
@sgrif
Member

sgrif commented Jan 31, 2016

Note: PRs addressing this issue should target the diesel-sqlite-support branch, not master.

When we establish a new SQLite connection in our tests, we immediately run the pending migrations. This spams the console. I have no clue why these aren't being swallowed.

@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016

@sgrif sgrif referenced this issue Jan 31, 2016

Merged

Initial support for SQLite3 #152

@mfpiccolo

This comment has been minimized.

Sign in to view
Collaborator

mfpiccolo commented Jan 31, 2016

I have a feeling this is linked to rust-lang/rust#12309

sgrif added a commit that referenced this issue Jan 31, 2016

@sgrif
Don't spam migration output during test runs 
Rust *should* be swallowing all stdout output during test runs, but for
some reason it isn't. This appears to be due to
rust-lang/rust#12309. However, we can't have
out test suite spam to the point of unreadability until that's fixed, so
let's just not output from migrations during tests.

This was paired, so it has been committed without PR.

Fixes #156.
b25be2f
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Jan 31, 2016

Fixed by b25be2f

@sgrif sgrif closed this Jan 31, 2016

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Don't spam migration output during test runs 
Rust *should* be swallowing all stdout output during test runs, but for
some reason it isn't. This appears to be due to
rust-lang/rust#12309. However, we can't have
out test suite spam to the point of unreadability until that's fixed, so
let's just not output from migrations during tests.

This was paired, so it has been committed without PR.

Fixes #156.
99ee207

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Don't spam migration output during test runs 
Rust *should* be swallowing all stdout output during test runs, but for
some reason it isn't. This appears to be due to
rust-lang/rust#12309. However, we can't have
out test suite spam to the point of unreadability until that's fixed, so
let's just not output from migrations during tests.

This was paired, so it has been committed without PR.

Fixes #156.
c2597b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment