/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLite] Add a backend agnostic way to create a table #158

Closed
sgrif opened this Issue Jan 31, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.5
1 participant
@sgrif
@sgrif
Member

sgrif commented Jan 31, 2016

Note: PRs addressing this issue should target the diesel-sqlite-support branch, not master.

We have a lot of tests which are duplicated based on the backend, simply because there's no backend agnostic way to define an auto incrementing primary key. Let's just bite the bullet and add an (internal only) DSL for this.

@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016

sgrif added a commit that referenced this issue Feb 1, 2016

@sgrif
Allow backend agnostic table creation in tests 
I have not added this DSL to the public API, as it's unsuitable for
public use at this time. It handles nothing other than the exact cases
that we need in our test suite, and requires you to manually quote
default values.

Fixes #158
93fec8f

sgrif added a commit that referenced this issue Feb 1, 2016

@sgrif
Allow backend agnostic table creation in tests 
I have not added this DSL to the public API, as it's unsuitable for
public use at this time. It handles nothing other than the exact cases
that we need in our test suite, and requires you to manually quote
default values.

Fixes #158
4f89622

@sgrif sgrif referenced this issue Feb 1, 2016

Merged

Allow backend agnostic table creation in tests #171

sgrif added a commit that referenced this issue Feb 1, 2016

@sgrif
Allow backend agnostic table creation in tests 
I have not added this DSL to the public API, as it's unsuitable for
public use at this time. It handles nothing other than the exact cases
that we need in our test suite, and requires you to manually quote
default values.

Fixes #158
Loading status checks…
f1e5324
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Feb 1, 2016

Fixed by #171

@sgrif sgrif closed this Feb 1, 2016

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Allow backend agnostic table creation in tests 
I have not added this DSL to the public API, as it's unsuitable for
public use at this time. It handles nothing other than the exact cases
that we need in our test suite, and requires you to manually quote
default values.

Fixes #158
f98e497

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Allow backend agnostic table creation in tests 
I have not added this DSL to the public API, as it's unsuitable for
public use at this time. It handles nothing other than the exact cases
that we need in our test suite, and requires you to manually quote
default values.

Fixes #158
98f85ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment