/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLite] Diesel should not have a hard dependency on libpq and libsqlite #159

Closed
sgrif opened this Issue Jan 31, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.5
1 participant
@sgrif
@sgrif
Member

sgrif commented Jan 31, 2016

Note: PRs addressing this issue should target the diesel-sqlite-support branch, not master.

Right now we currently always compile against both. We should only compile against whatever the user wants to use. They should both be able to co-exist in the same app if desired. This can either be done via features, or by moving SQLite and PG into separate crates. I have no preference as to which solution we do, but we should isolate the backend specific things to a single top level module in either case so we don't end up littering #[cfg(feature="whatever")] into our code.

@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016

sgrif added a commit that referenced this issue Feb 2, 2016

@sgrif
Remove hard dependencies on `libpq` and `libsqlite3` 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
c675b47

@sgrif sgrif referenced this issue Feb 2, 2016

Merged

Remove hard dependencies on `libpq` and `libsqlite3` #175

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Remove hard dependencies on `libpq` and `libsqlite3` 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
f629171

sgrif added a commit that referenced this issue Feb 3, 2016

@sgrif
Remove hard dependencies on `libpq` and `libsqlite3` 
All code which *directly* depends on these has been moved to a separate
module and placed behind a cfg attr. There is still a ton of PG specific
stuff hidden in the expressions module that simply isn't marked as such.

I had to rework how we do our boilerplate type impls, as `sqlite` and
`postgres` need to be able to co-exist in the same compile pass (even
just for generating docs).

While this PR is pretty large, it ultimately mostly comes down to
clerical work.

Fixes #159.
d9f733f
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Feb 3, 2016

Fixed by #175.

@sgrif sgrif closed this Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment