New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we still compile on Windows #160

Closed
sgrif opened this Issue Jan 31, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@sgrif
Member

sgrif commented Jan 31, 2016

I need to set up Appveyor for master, I will do that tomorrow. Since we've added new C deps, we need to verify that this still works on Windows given a reasonable installation.

@sgrif sgrif added this to the 0.5 milestone Jan 31, 2016

@chriskrycho

This comment has been minimized.

chriskrycho commented Jan 31, 2016

What exactly constitutes a "reasonable installation"? I've got Windows VMs set up for other reasons, would be happy to test it and see what pops out, if anything.

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 31, 2016

Excellent question. I've not tried installing SQLite support on my Windows laptop, so I'm not sure how to qualify it for that, but the way I'd describe it for postgres is "Having installed PG from the links on their website, and made sure C:\Program Files\PostgreSQL\{version}\bin is on the %PATH%" (The second half being non-obvious, but unfortunately required).

@chriskrycho

This comment has been minimized.

chriskrycho commented Jan 31, 2016

I'll give it a whirl sometime tomorrow; at the very least I should be able to report what's broken out of the gate as a totally-new user.

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 31, 2016

Thanks. I'll probably merge #152 around lunch tomorrow once I have time to address stuff in the morning (I'm in UTC-7 if you want to get specific). I'll try to get Appveyor set up in the morning, too if you want to tackle getting SQLite working for that (they don't offer SQLite as a "service" and I'm not sure how well things like chocolatey work on that service)

@chriskrycho

This comment has been minimized.

chriskrycho commented Jan 31, 2016

@sgrif

This comment has been minimized.

Member

sgrif commented Jan 31, 2016

Hah, no pressure. <3

@sgrif sgrif changed the title from [SQLite] Make sure we still compile on Windows to Make sure we still compile on Windows Feb 3, 2016

@sgrif

This comment has been minimized.

Member

sgrif commented Feb 5, 2016

The CLI tests fail against SQLite due to some contention over file locks (/cc @mcasper), but other than that everything is still fine on Windows.

@sgrif sgrif closed this Feb 5, 2016

@chriskrycho

This comment has been minimized.

chriskrycho commented Feb 5, 2016

@mcasper

This comment has been minimized.

Collaborator

mcasper commented Feb 5, 2016

I think we're going to have to move to single threaded integration tests for the CLI anyways, so that should get cleared up soon.

@sgrif

This comment has been minimized.

Member

sgrif commented Feb 5, 2016

Our integration tests shouldn't need to be single threaded. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment