Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake sure we still compile on Windows #160
Comments
sgrif
added this to the 0.5 milestone
Jan 31, 2016
This comment has been minimized.
chriskrycho
commented
Jan 31, 2016
|
What exactly constitutes a "reasonable installation"? I've got Windows VMs set up for other reasons, would be happy to test it and see what pops out, if anything. |
This comment has been minimized.
|
Excellent question. I've not tried installing SQLite support on my Windows laptop, so I'm not sure how to qualify it for that, but the way I'd describe it for postgres is "Having installed PG from the links on their website, and made sure |
This comment has been minimized.
chriskrycho
commented
Jan 31, 2016
|
I'll give it a whirl sometime tomorrow; at the very least I should be able to report what's broken out of the gate as a totally-new user. |
This comment has been minimized.
|
Thanks. I'll probably merge #152 around lunch tomorrow once I have time to address stuff in the morning (I'm in UTC-7 if you want to get specific). I'll try to get Appveyor set up in the morning, too if you want to tackle getting SQLite working for that (they don't offer SQLite as a "service" and I'm not sure how well things like chocolatey work on that service) |
This comment has been minimized.
chriskrycho
commented
Jan 31, 2016
|
If I get the time, I’ll be happy to! (No promises; every time I make a promise in OSS I break it and am sad.)
|
This comment has been minimized.
|
Hah, no pressure. <3 |
sgrif
added
good first issue
sqlite
labels
Feb 3, 2016
sgrif
changed the title from
[SQLite] Make sure we still compile on Windows
to
Make sure we still compile on Windows
Feb 3, 2016
This comment has been minimized.
|
The CLI tests fail against SQLite due to some contention over file locks (/cc @mcasper), but other than that everything is still fine on Windows. |
sgrif
closed this
Feb 5, 2016
This comment has been minimized.
chriskrycho
commented
Feb 5, 2016
|
Huzzah! (Sorry I couldn’t help. But still: huzzah!)
|
This comment has been minimized.
|
I think we're going to have to move to single threaded integration tests for the CLI anyways, so that should get cleared up soon. |
This comment has been minimized.
|
Our integration tests shouldn't need to be single threaded. ;) |
sgrif commentedJan 31, 2016
I need to set up Appveyor for master, I will do that tomorrow. Since we've added new C deps, we need to verify that this still works on Windows given a reasonable installation.