Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRunMigrationsError provides no information about the specific migration that failed #1605
Comments
This comment has been minimized.
|
Copying my comments from the gitter convo (and pinging the power rangers): I can say with certainty that I intended to make that enum (and MigrationError) extensible, and it slipped through the cracks |
This comment has been minimized.
|
I think a couple of improvements could be made in the process: the names of some of the functions are a little odd (for example, the function to find all the migrations is called This would be a good opportunity to refactor some of this: for example creating a |
This comment has been minimized.
|
Yeah, a redesign was originally planned for 1.0 but we agreed that we could \ deprecate the current API backwards compatibly. That does not apply to types |
Aaron1011 commentedMar 28, 2018
While RunMigrationsError provides information about the type of migration error that occurred, it provides no information (e.g. the file path) about the specific migration that caused the error.
Since the
RunMigrationsErrorenum has neither anon_exhaustiveattribute nor a#[doc(hidden)]variant, adding new variants is a breaking change. It was suggested on Gitter that a new error type (and corresponding functions) be created, and that the currentRunMigrationsErrorandrun_migrationsbe deprecated.