New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better way to deprecate old feature names #1636

Open
sgrif opened this Issue Apr 12, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@sgrif
Member

sgrif commented Apr 12, 2018

The current way we're deprecating the various x-column-tables feature spams builds with an unreasonable number of warnings, and causes our crate to fail to compile if we have #![deny(warnings)]. Ideally we show the warning in the actual invocation of table!, but rust-lang/rust#49912 prevents us from just doing the obvious thing there.

We should find a better solution though, that doesn't spam logs, and in particular, generates no warnings from inside Diesel itself when compiled with these features turned on. The solution of "remember to remove #[deny(warnings)] when we release isn't going to work long term.

@sgrif sgrif added this to the 1.3 milestone Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment