Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFigure out a better way to deprecate old feature names #1636
Comments
sgrif
added this to the 1.3 milestone
Apr 12, 2018
sgrif
referenced this issue
Apr 12, 2018
Closed
Diesel with large-tables feature is not compiling #1634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedApr 12, 2018
•
edited
The current way we're deprecating the various x-column-tables feature spams builds with an unreasonable number of warnings, and causes our crate to fail to compile if we have
#![deny(warnings)]. Ideally we show the warning in the actual invocation oftable!, but rust-lang/rust#49912 prevents us from just doing the obvious thing there.We should find a better solution though, that doesn't spam logs, and in particular, generates no warnings from inside Diesel itself when compiled with these features turned on. The solution of "remember to remove
#[deny(warnings)]when we release isn't going to work long term.