Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce a `without-deprecated` feature #1638
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedApr 12, 2018
We have a lot of deprecations which do not give a warning due to various bugs in Rust. We've been recommending that people try compiling their apps with default features turned off if they're concerned about relying on deprecated code. However, this isn't always enough. If any dependency in the entire graph depends on Diesel without
default-features = false, you cannot get rid of deprecated code.We should introduce an explicit
without-deprecatedfeature meant specifically for "just make sure I'm not depending on deprecated code" testing. Any place where we havefeature = "with-deprecated"will need to change toall(feature = "with-deprecated", not(feature = "without-deprecated")).In an ideal world we shouldn't need this, and nobody should have to wonder if they're relying on deprecated code. However, the number of deprecations we have that do not warn are at a volume where I think this is warranted.
For reference, a few of the bugs in question:
rust-lang/rust#49912
rust-lang/rust#47237
rust-lang/rust#47236
rust-lang/rust#47238