Yank old versions of diesel_codegen

[weiznich]

We seeing quite periodic questions/bugreports about something broken in diesel that boils down to someone tries to use the old diesel_codegen.
I suggest to yank at least the 0.16 version to indicate that this crate shouldn't be used anymore.

[Eijebong]

@weiznich What if I want to use diesel 0.16 though ? :/
I agree that those questions are way too frequent but yanking old versions doesn't sound like a good solution to me.

[weiznich]

An other solution would be to publish a empty version as 0.17 or so that does print an error message saying not to use this crate anymore in compilation with recent diesel versions.

[sgrif]

I'm with @Eijebong on this, I don't think yanking old versions of this crate is a good idea.

[weiznich]

So what's about releasing diesel_codegen 0.17 that gives error messages not to use that crate?
If someone wants to use diesel 0.16 it is an intentional decision and that person will use diesel_codegen 0.16. If someone uses diesel_codegen by accident (or old guides) there is a message what's wrong. Old projects using diesel 0.16 will continue to work because going from 0.16 to 0.17 indicates a breaking change.

[sgrif]

I'm not sure how that's helpful. The issue is people with existing 0.16 projects updating Diesel to 0.99 or 1.0 and leaving diesel_codegen there. It's not like they'd randomly decide to go to 0.17.

[Eijebong]

If there's a way to get the version of diesel used in a build script, we could add one which makes the compilation fail and release 0.16.whatever

[weiznich]

The issue is people with existing 0.16 projects updating Diesel to 0.99 or 1.0 and leaving diesel_codegen there.

I'm not sure if that's really the issue. (Let's just ask the next person with that problem 😉)

It's not like they'd randomly decide to go to 0.17.

If they are updating diesel I assume they will also update diesel_codegen to the latest version. In that case will releasing a newer version emitting some error message point them into the right direction.

If there's a way to get the version of diesel used in a build script, we could add one which makes the compilation fail and release 0.16.whatever

So we just need to parse Cargo.toml/Cargo.lock? 🙈

[sgrif]

So we just need to parse Cargo.toml/Cargo.lock? 🙈

TBH that actually sounds fairly reasonable

[weiznich]

Fixed by publishing 0.16.1 of diesel_codegen.