diesel_cli v1.3 print-schema broken on WIN10

[Deedasmi]

Setup

With diesel_cli 1.2:

diesel print-schema gives correct output.

With diesel_cli 1.3:
diesel print-schema gives

Access is denied. (os error 5)

Versions

• Rust: nightly-2018-05-14/1.26 Stable
• Diesel: 1.3
• Database: PG10
• Operating System WIN10

Feature Flags

• diesel: Postgres

Checklist

• [ X ] I have already looked over the issue tracker for similar issues.
• [ X ] This issue can be reproduced on Rust's stable channel.

Doing some troubleshooting, but it's 1 am and I might pass out. Will figure out cause tomorrow at latest.

[weiznich]

This sounds like you don't have the needed rights to read from the postgres information schema with your current user.

[Deedasmi]

Why would it work on the previous version then? I downgraded to 1.2 and it worked fine.

I've tracked the error down to https://github.com/diesel-rs/diesel/blob/master/diesel_cli/src/print_schema.rs#L57, but haven't figured out why its failing yet.

[Deedasmi]

extern crate tempfile;
use tempfile::NamedTempFile;
use std::fs::File;
use std::io;

fn main() -> Result<(), io::Error> {
    let tempfile = NamedTempFile::new()?;
    let mut out = File::create(tempfile)?;
    Ok(())
}

Fails on my system. Seems like this is an issue with tempfile.

[weiznich]

Is your temp directory writable for your current user? If not this seems more like a system configuration issue.

[Deedasmi]

Opened Stebalien/tempfile#56.

Made a better test where I can write a PathBuf file, but not a NamedTempFile. This one looks... fun lol.

[Deedasmi]

I actually think diesel is using tempfile incorrectly. https://docs.rs/tempfile/3.0.2/src/tempfile/file/mod.rs.html#371-374

NamedTempFile already creates a File. By passing the path to File::create() we're trying to create a new file on top of an open file handle.

[KodrAus]

@Deedasmi that's right, NamedTempFile::new will create the temporary file it wraps before it returns.