/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any remaining `FIXME`s related to SQLite support #173

Closed
sgrif opened this Issue Feb 2, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  0.5
1 participant
@sgrif
@sgrif
Member

sgrif commented Feb 2, 2016

This is a blanket reminder issue, as I'm not sure I have an individual issue for each of these. Any that can be resolved for 0.5 should. Any that we are not going to fix in 0.5 should still be removed, and have a separate issue opened for them.

If you're reading this and you've found a specific comment which doesn't have an issue, please open one.

@sgrif sgrif added this to the 0.5 milestone Feb 2, 2016

@mcasper mcasper changed the title from [SQLite] Remove any remainging `FIXME`s to [SQLite] Remove any remaining `FIXME`s Feb 3, 2016

@mcasper mcasper referenced this issue Feb 3, 2016

Closed

Remove internal copy of Path#strip_prefix when 1.7 is stable #183

@sgrif sgrif changed the title from [SQLite] Remove any remaining `FIXME`s to Remove any remaining `FIXME`s related to SQLite support Feb 3, 2016

@sgrif sgrif added good first issue sqlite labels Feb 3, 2016

sgrif added a commit that referenced this issue Feb 5, 2016

@sgrif
Fix remaining FIXMEs that are going to be fixed in 0.5 
This adds two new missing features to `SQLite`. A `ToSql` impl for
`Bool`, and an implementation of `save_changes`. I wanted to keep the
blanket impl for `SupportsReturningKeyword`, but it looks like I can't
rely on `Sqlite` not implementing it from the user's crate. I think this
will just get moved in crate once we solve #179 anyway.

There are still some remaining things to be addressed, such as the lack
of support for numeric and date types, but those are out of scope for
0.5.

Fixes #173.
fb19528

@sgrif sgrif referenced this issue Feb 5, 2016

Merged

Fix remaining FIXMEs that are going to be fixed in 0.5 #195

@sgrif sgrif closed this in #195 Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment