New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/lib.rs from getting started guide is different from github source. #1758

Open
Qwertie- opened this Issue Jun 11, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Qwertie-

Qwertie- commented Jun 11, 2018

On the getting started guide
the use section of src/lib.rs contains

use diesel::prelude::*;
use diesel::pg::PgConnection;
use dotenv::dotenv;
use std::env;

but in the github source it contains

use diesel::prelude::*;
use dotenv::dotenv;
use std::env;

@weiznich

This comment has been minimized.

Contributor

weiznich commented Jul 6, 2018

Both are equivalent because diesel::prelude exports PgConnection if the as soon as the postgres feature is enabled.
That said it would be great to fix this inconsistency. If you (or somebody else) is interested to open a PR: The source for the web page is here

tyre added a commit to tyre/diesel that referenced this issue Aug 22, 2018

Align getting started example imports with repo
While the prelude imports `PgConnection`, it's a confusing mis-match for beginners.

Fixes diesel-rs#1758

@tyre tyre referenced a pull request that will close this issue Aug 22, 2018

Open

Align getting started example imports with repo #1824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment