/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal copy of Path#strip_prefix when 1.7 is stable #183

Closed
mcasper opened this Issue Feb 3, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@mcasper @sgrif @emptyflash
@mcasper
Collaborator

mcasper commented Feb 3, 2016

Specific issue for a FIXME per #173

As of b1a215b, this FIXME is located here: https://github.com/sgrif/diesel/blob/master/diesel_cli/src/main.rs#L289
@sgrif

This comment has been minimized.

Sign in to view
Member

sgrif commented Feb 3, 2016

Permalink: https://github.com/sgrif/diesel/blob/b1a215b/diesel_cli/src/main.rs#L289

@sgrif sgrif added the cli label Feb 3, 2016

@sgrif sgrif changed the title from [CLI] Remove internal copy of Path#strip_prefix when 1.7 is stable to Remove internal copy of Path#strip_prefix when 1.7 is stable Feb 3, 2016

@sgrif sgrif added the good first issue label Feb 3, 2016

@emptyflash

This comment has been minimized.

Sign in to view
Contributor

emptyflash commented Feb 3, 2016

Just to be clear, relative_from isn't being used because it's marked unstable (rust-lang/rust#23284), so once 1.7 is stable we should replace strip_prefix with Path#strip_prefix?

@emptyflash emptyflash referenced this issue Mar 3, 2016

Merged

Removed internal copy of Path#strip_prefix #230

@mcasper

This comment has been minimized.

Sign in to view
Collaborator

mcasper commented Mar 4, 2016

Resolved by #230

@mcasper mcasper closed this Mar 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment