Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate versions of syn/quote/proc-macro2 #1848
Comments
This comment has been minimized.
bobtwinkles
commented
Sep 12, 2018
|
For what it's worth, I'm willing to take a stab at fixing this if nobody else is working on it. |
This comment has been minimized.
|
54b21b0 It's already on master |
Eijebong
closed this
Sep 12, 2018
This comment has been minimized.
bobtwinkles
commented
Sep 12, 2018
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bobtwinkles commentedSep 12, 2018
Setup
Add
diesel = 1.3to a crate's Cargo.tomlVersions
rustc 1.29.0-nightly (12ed235ad 2018-07-18)orrustc 1.27.1 (5f2b325f6 2018-07-07)Feature Flags
Problem Description
Using
serdeanddieselin the same project result in 2 versions of thesyn/quote/proc-macro2constellation of crates being compiled. It would be better if this didn't happen.What are you trying to accomplish?
Use
serdeanddieselin the same crateWhat is the expected output?
Only one version of
syn/quote/proc-macro2is compiled.What is the actual output?
Two versions are compiled:
From
serde_derive 1.0.78we have:proc-macro2 0.4.19quote 0.6.8syn 0.15.4From
diesel_derive 1.3.0:proc-macro2 0.3.8quote 0.5.2syn 0.13.11Are you seeing any additional errors?
No.
Steps to reproduce
Add Serde and Diesel to the same crate
Checklist
closed if this is not the case)