New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Numeric to SQLite #185

Closed
sgrif opened this Issue Feb 3, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@sgrif
Member

sgrif commented Feb 3, 2016

As far as I can tell, there is no "internal" representation of this that we can deserialize to (like we did with PgNumeric). As such, we should probably have this deserialize to a string, as that's the only type that we can reasonably implement FromSql for without losing precision. We can add ToSql impls for f32 and f64 and/or the various integer types if we think it's useful enough.

@sgrif sgrif added the sqlite label Feb 3, 2016

@sgrif sgrif changed the title from [SQLite] Add support for Numeric to Add support for Numeric Feb 3, 2016

@sgrif sgrif changed the title from Add support for Numeric to Add support for Numeric to SQLite Feb 3, 2016

@sgrif

This comment has been minimized.

Member

sgrif commented Feb 18, 2016

Upon further investigation, SQLite appears to have no visible difference in behavior between numeric and double precision floats. If anybody knows this to be incorrect, please let me know.

@sgrif sgrif closed this Feb 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment