/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `IN` statements #186

Closed
sgrif opened this Issue Feb 3, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  0.5
1 participant
@sgrif
@sgrif
Member

sgrif commented Feb 3, 2016

Prior to 1.5 there was no need for it, as we could use eq(any()) instead, which is more friendly to prepared statements. However, the any operator is PG specific. We need to be careful with this, as it could cause unbounded growth of prepared statements.

@sgrif sgrif added the sqlite label Feb 3, 2016

@sgrif sgrif added this to the 0.5 milestone Feb 3, 2016

sgrif added a commit that referenced this issue Feb 5, 2016

@sgrif
Add support for `IN` statements. 
We didn't have a use for this previously, as PG supports `= ANY` which
is more friendly to prepared statements. Since SQLite does not support
this operator, we need to fall back to `IN`. Eventually I'd like to have
this just "do the right thing" on PG, but that's out of scope for 0.5.

The name `eq_any` was chosen both to allow me to change the behavior on
PG in the future, and also because `in` is a keyword in Rust and cannot
be used as a function name.

Fixes #186
1621355

@sgrif sgrif referenced this issue Feb 5, 2016

Merged

Add support for `IN` statements. #193

@mfpiccolo mfpiccolo closed this in #193 Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment