New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid 0.7 not being used because of features in manifest #1900

Open
jkcclemens opened this Issue Oct 30, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@jkcclemens

jkcclemens commented Oct 30, 2018

Setup

Versions

  • Rust: rust version 1.30.0 (da5f414c2 2018-10-24)
  • Diesel: 1.3.3
  • Database: Any
  • Operating System: Any

Feature Flags

  • diesel: uuid

Problem Description

As far as I can tell, uuid 0.7 will never be used because it doesn't match the requirements. While 0.7 is indeed >= 0.2 and < 0.8.0, it does not have a use_std feature, which locks uuid to 0.6. The feature was renamed to std in 0.7 and is a default feature.

I forked diesel and changed Cargo.toml to use std, then used a patch section in one of my projects. Updating to my fork removed uuid 0.6 and added uuid 0.7. Reverting back to the official git adds uuid 0.6 back.

Checklist

  • I have already looked over the issue tracker for similar issues.
  • This issue can be reproduced on Rust's stable channel. (Your issue will be
    closed if this is not the case)
@weiznich

This comment has been minimized.

Contributor

weiznich commented Oct 30, 2018

Uuid 0.7 get's never used because the last release of diesel has no support for uuid 0.7, only master supports the new version.

@weiznich weiznich closed this Oct 30, 2018

@jkcclemens

This comment has been minimized.

jkcclemens commented Oct 30, 2018

No, master does not. That's why I made this issue.

master explicitly will not use uuid 0.7, since uuid 0.7 misses the feature that master requests.

@weiznich

This comment has been minimized.

Contributor

weiznich commented Oct 30, 2018

If uuid changed the name of that feature there is no way for diesel to support both versions. That means we cannot update uuid to a newer version without releasing diesel 2.0 because this would remove support for old versions of uuid.

@jkcclemens

This comment has been minimized.

jkcclemens commented Oct 30, 2018

Perhaps you should revert #1861 to explicitly show that you won't support uuid 0.7, then.

For what it's worth, use_std was deprecated in uuid 0.6.

@weiznich weiznich reopened this Oct 30, 2018

@weiznich

This comment has been minimized.

Contributor

weiznich commented Oct 30, 2018

For what it's worth, use_std was deprecated in uuid 0.6.

This doesn't help us because we also support older versions of uuid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment