Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDiesel CLI's tests leave files laying around if tests fail #222
Comments
sgrif
assigned
mcasper
Feb 19, 2016
This comment has been minimized.
|
The tests that do that are probably obsolete now, or could be replaced by integration tests. I'll take a look tonight |
mcasper
referenced this issue
Feb 28, 2016
Merged
Remove database tests and replace with integration tests #223
mcasper
closed this
in
#223
Mar 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedFeb 19, 2016
I'm working on some test failures that are occuring on Windows for Diesel CLI, and noticed that the tests in the database module aren't structured properly. They rely on calling a teardown function at the end, but that function is never called if the tests fail. These tests need to operate inside of a tempdir instead so that cleanup happens automatically. /cc @mcasper