New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diesel_codegen depends on old version of diesel #273

Closed
tari opened this Issue Apr 15, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@tari
Contributor

tari commented Apr 15, 2016

I think somebody forgot to bump the version of the diesel dependency in diesel_codegen when releasing version 0.6, since it currently depends on 0.5.0. I'm not sure what the effects of such a thing would be, but probably nothing good and possibly confusing errors.

@sgrif

This comment has been minimized.

Member

sgrif commented Apr 16, 2016

I think somebody forgot

Heh. I appreciate politely avoiding calling out my dumb mistake. 🙉 🙈 🙊

@sgrif

This comment has been minimized.

Member

sgrif commented Apr 16, 2016

Interestingly, I think the effects of this would be relatively minor. The version of Diesel that codegen uses wouldn't affect the code that it generates. Really the only thing that CLI and Codegen are affected by from Diesel is the Connection, which didn't have any changes to it in 0.6. Either way, we should point at the latest version because it's silly not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment