New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*ANY* breaking changes that we want to make in the near future #298

Closed
sgrif opened this Issue Apr 23, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@sgrif
Member

sgrif commented Apr 23, 2016

Right now the plan is to have 0.7 be the last release before 1.0. That means that we should start seriously thinking about anything we might want to break in the near future. This does not mean that we should feel rushed to get remaining major features out. Only that we should address anything we expect to cause breaking changes.

A few things that we should look at off the top of my head

  • group_by support, and how this affects NonAggregate. Honestly, I think we're so far from this that it'll have to wait until 2.0 if it needs breaking changes (it might not need breaking changes though). This likely requires some form of negative reasoning in the language. Regardless, I need to take a swing at it before 1.0
  • Logging. Does this eliminate the need for debug_sql! and the Debug backend?
  • Reforming joins to work with multiple tables. Does the improved association support in 0.7 eliminate the majority of the need for this?
@iqualfragile

This comment has been minimized.

iqualfragile commented May 11, 2016

maybe support for composite primary keys? I guess that would mean some changes, not sure if the api would change though.

@sgrif

This comment has been minimized.

Member

sgrif commented May 11, 2016

Yes you are right we should attempt to explore that in 0.7 or 0.8

On Wed, May 11, 2016, 10:16 AM iqualfragile notifications@github.com
wrote:

maybe support for composite primary keys? I guess that would mean some
changes, not sure if the api would change though.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#298 (comment)

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 30, 2017

Everything in this issue has been resolved. group_by is going to wait for 2.0. Logging has been removed from the milestone (we can add it backwards compatibly I think, though it'll require a default impl of the set_logger method on Connection which panics). Joins have been sufficiently reformed.

@sgrif sgrif closed this Jul 30, 2017

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 30, 2017

Also...

Right now the plan is to have 0.7 be the last release before 1.0

Yeah, that worked out well... >_>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment