New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the 0.6.2 version? #345

Closed
KokaKiwi opened this Issue May 27, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@KokaKiwi

KokaKiwi commented May 27, 2016

The crate r2d2-diesel use the crates.io release of diesel, which cause problem with the git version because diesel is at version 0.6.1 on the git repository.
Why not bumping the git version to 0.6.2 to in order to fix this?

@sgrif

This comment has been minimized.

Member

sgrif commented May 29, 2016

r2d2-diesel uses diesel = ">= 0.5.0, < 0.7.0"

@sgrif sgrif closed this May 29, 2016

@nox

This comment has been minimized.

nox commented May 30, 2016

You published diesel 0.6.2 but it's not in the Git repository. Did it become closed-source?

@Eijebong

This comment has been minimized.

@nox

This comment has been minimized.

nox commented May 30, 2016

Ok, you just forgot to push the branch then?

https://github.com/diesel-rs/diesel/blob/master/diesel/Cargo.toml#L3

@sgrif

This comment has been minimized.

Member

sgrif commented May 30, 2016

There is no branch, it was a single cherry picked commit

On Mon, May 30, 2016, 4:54 AM Anthony Ramine notifications@github.com
wrote:

Ok, you just forgot to push the branch then?

https://github.com/diesel-rs/diesel/blob/master/diesel/Cargo.toml#L3


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#345 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABdWKwgZjiQBAgOqICOx4XUkKOBc7wJcks5qGqXEgaJpZM4IoOXh
.

@nox

This comment has been minimized.

nox commented May 30, 2016

That doesn't explain why master isn't 0.6.2. Could you make master the 0.6.2 version as expected?

@sgrif

This comment has been minimized.

Member

sgrif commented May 30, 2016

Because 0.6.2 was a minor patch on 0.6.1 done long after master had changes
that I didn't want to release

On Mon, May 30, 2016, 6:02 AM Anthony Ramine notifications@github.com
wrote:

That doesn't explain why master isn't 0.6.2. Could you make master the
0.6.2 version as expected?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#345 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABdWK3qAK6MIyevzyHqxaUL9Ygfq0e53ks5qGrXOgaJpZM4IoOXh
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment