New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diesel_codegen v0.6.2 does not build. #370

Closed
MrBlobbyJr opened this Issue Jul 3, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@MrBlobbyJr

MrBlobbyJr commented Jul 3, 2016

TokenTree has been moved from ast to tokenstream in syntex_syntax recent update:
diesel_codegen -0.6.2\src\schema_inference/mod.rs:52:12: 52:26 help: you can import it into scope: use syntax::tokenstream::TokenTree;.

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 3, 2016

Thank you for the report. Because keeping up with nightly perpetually causes a lot of churn, our policy is currently that we will support nightlies on the dates that Rust releases. This means that the next nightly we will support will be on July 7th (because I am at a conference, it may not get updated until a few days after that date, but that will be the date we target). Thanks for your patience and understanding.

@sgrif sgrif closed this Jul 3, 2016

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 3, 2016

Ah this looks like a breaking change in a minor update actually. We may need to lock down the version further. /cc @erickt did something break in a semver incompatible way? I've gotten 3 reports about this.

@sgrif sgrif reopened this Jul 3, 2016

@erickt

This comment has been minimized.

erickt commented Jul 3, 2016

cc @dtolnay

@sgrif: where is this crate defined? In diesel_codegen I just see 0.6.1, which is pinned to a specific syntex version, 0.31.0.

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 4, 2016

Yes that's where it should be. Specifying 0.31.0 is basically 0.31.*

@dtolnay

This comment has been minimized.

dtolnay commented Jul 4, 2016

@sgrif Syntex does not make breaking changes in minor updates. Cargo does not consider 0.x.0 and 0.(x+1).0 to be semver-compatible.

@MrBlobbyJr diesel_codegen builds just fine using syntex. It does not build on the latest nightly but @sgrif says that is not supported.

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 4, 2016

Ok just wanted to make sure since the issue mentioned syntex_syntax (I'm out of the country ATM so I haven't had a ton of time). And yeah we'll update nightlies on the 7th (and likely ship 0.7.0 on that date). We'll update syntex and friends on that date as well. Thanks for looking into it @dtolnay

@sgrif sgrif closed this Jul 4, 2016

@porglezomp

This comment has been minimized.

porglezomp commented Jul 6, 2016

The policy and the date of the most recent release (perhaps with the rustup override invocation needed to get it) should probably be somewhere more prominent in order to prevent this confusion in the future.

@sgrif

This comment has been minimized.

Member

sgrif commented Jul 7, 2016

Yes, I will document it when I handle the next update (which will likely actually be on the 11th or 12th when I get home, but will target the nightly from the 7th assuming Rust ships today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment