New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.10 stabilised {Occupied,Vacant,}Entry::key #388

Closed
killercup opened this Issue Jul 30, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@killercup
Member

killercup commented Jul 30, 2016

A comment here says:

// FIXME: This can be cleaned up once https://github.com/rust-lang/rust/issues/32281
// is stable

This has been stabilised in Rust 1.10 (cf. rust-lang/rust#33699).

@cengizIO

This comment has been minimized.

Contributor

cengizIO commented Aug 1, 2016

Hello!

I can work on this, if there's nobody already assigned.

@sgrif

This comment has been minimized.

Member

sgrif commented Aug 1, 2016

Have at it!

@cengizIO

This comment has been minimized.

Contributor

cengizIO commented Aug 2, 2016

Hello @killercup, @sgrif

I replaced old if block with new matchers but currently having borrowing/ownership issues.

I brought a Postgres docker instance up and fixing borrow checker errors one by one.

Will submit a PR in following days.

Thanks

@gsquire

This comment has been minimized.

Contributor

gsquire commented Aug 2, 2016

@cengizIO

This comment has been minimized.

Contributor

cengizIO commented Aug 10, 2016

Sorry it's been a very busy week.

I'm back to working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment