New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test custom_derive integration #393

Closed
killercup opened this Issue Aug 1, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@killercup
Member

killercup commented Aug 1, 2016

Many of the macro_rules! macros can be used with the custom_derive crate, e.g. BelongsTo! or Identifiable!. This is documented, by not tested.

We should (as a first step) add custom_derive as a dev dependency and expand the documentation code blocks to actually work as doc tests.

@shssoichiro

This comment has been minimized.

Contributor

shssoichiro commented Sep 9, 2016

I'd like to work on this one.

@killercup

This comment has been minimized.

Member

killercup commented Sep 9, 2016

@shssoichiro Oh! You might want to hold off on this one right now. There are known bugs when using custom_derive! and we'll probably not spend much time fixing them and instead build something using macros 1.1.

@shssoichiro

This comment has been minimized.

Contributor

shssoichiro commented Sep 9, 2016

Got it! I'll check back later if this still ends up being necessary.

@sgrif

This comment has been minimized.

Member

sgrif commented Sep 12, 2016

Closing as it turns out custom-derive is completely broken and we're just going to remove it from the docs now that Macros 1.1 is a thing.

@sgrif sgrif closed this Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment