Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcustom_derive is broken and we should stop pretending to support it #438
Comments
sgrif
added
good first issue
documentation
labels
Sep 12, 2016
sgrif
referenced this issue
Sep 12, 2016
Closed
Identifiable!, BelongsTo!, HasMany! are brocken when used with custom_derive #430
added a commit
to weiznich/diesel
that referenced
this issue
Sep 13, 2016
sgrif
closed this
in
#440
Sep 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedSep 12, 2016
We should remove all references to custom_derive from our documentation.
A few macros work, but several do not and will not be able to work without API changes that I'm not happy with. The push for stable macros was done before Macros 1.1 was a thing that was proposed. That RFC has since been accepted and implemented. It's likely to be stabilized in a reasonable amount of time, and is our story for stable going forward.