New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation around syntex #439

Closed
sgrif opened this Issue Sep 13, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@sgrif
Member

sgrif commented Sep 13, 2016

We have received complaints and state in our getting started guide that we're incompatible with the most recent versions of serde because we don't support the most recent version of syntex. However, the standard way to use syntex no longer involves the users depending on it directly, allowing for multiple versions to be used in the same code base. We should update our docs accordingly (see serde's docs for an example)

@killercup

This comment has been minimized.

Member

killercup commented Jan 1, 2017

Actually, we will need to update the guide on how to use the codegen crate with macros 1.1 in stable Rust 1.15 instead soon :)

@beatgammit

This comment has been minimized.

beatgammit commented Jan 31, 2017

Rust 1.15 should be out this week, is there any preliminary documentation?

I tried compiling on the beta branch and I get compile errors on diesel_codegen: ("#[feature] may not be used on the beta channel") using the latest diesel_codegen 0.9.0 on crates.io and beta 1.15.0-beta.5 (built Jan 19). If I build from the latest git head, I get a different compile error, but in infer_schema!, so I guess it's just not published yet (I can file that compile error separately if you like, but here's the invocation: infer_schema!("dotenv:DATABASE_URL");, and .env: DATABASE_URL=test.sqlite).

@sgrif

This comment has been minimized.

Member

sgrif commented Feb 1, 2017

You'll need to use master if you're using 1.15 beta. The guide will be updated tomorrow.

@beatgammit

This comment has been minimized.

beatgammit commented Feb 2, 2017

Awesome. Will a new crate be pushed soon with support for stable Rust?

@killercup

This comment has been minimized.

Member

killercup commented Feb 2, 2017

@sgrif sgrif closed this Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment