Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPG's documentation lies. Not all errors have messages #445
Comments
sgrif
changed the title from
Diesel panics if a fatal error is returned
to
PG's documentation lies. Not all errors have messages
Sep 17, 2016
This comment has been minimized.
|
Ok so a fatal error is actually the only kind of error... So the docs just straight up appear to be lying. For posterity, the error that causes this issue is a query with more than 34434 bind parameters. |
sgrif
closed this
Dec 10, 2016
This comment has been minimized.
|
My assumptions here were wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedSep 17, 2016
We're treating all non-OK return codes as an error, and then later assuming that all errors have a message. However, fatal errors appear to be exempt from this, and we need to bubble that up, not panic.