Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upA few of our tests are quite flaky #475
Comments
sgrif
added
the
good first issue
label
Oct 10, 2016
This comment has been minimized.
|
Hi ! Is it easy to detect flakyness locally, e.g. would just rerunning the suite couple of times locally give you intermittent failures ? |
This comment has been minimized.
|
Running it locally a few times should show failures yes On Wed, Oct 12, 2016, 1:07 AM Cyryl Płotnicki notifications@github.com
|
This comment has been minimized.
|
I'm interested in fixing it, will try to get a PR on the weekend possibly |
sgrif commentedOct 10, 2016
Specifically the tests in https://github.com/diesel-rs/diesel/blob/master/diesel_codegen_shared/src/database_url.rs are failing intermittently. The fix is likely just to make sure each test has a uniquely named environment variable that it's working with.