New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few of our tests are quite flaky #475

Closed
sgrif opened this Issue Oct 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@sgrif
Member

sgrif commented Oct 10, 2016

Specifically the tests in https://github.com/diesel-rs/diesel/blob/master/diesel_codegen_shared/src/database_url.rs are failing intermittently. The fix is likely just to make sure each test has a uniquely named environment variable that it's working with.

@cyplo

This comment has been minimized.

Contributor

cyplo commented Oct 12, 2016

Hi ! Is it easy to detect flakyness locally, e.g. would just rerunning the suite couple of times locally give you intermittent failures ?

@sgrif

This comment has been minimized.

Member

sgrif commented Oct 12, 2016

Running it locally a few times should show failures yes

On Wed, Oct 12, 2016, 1:07 AM Cyryl Płotnicki notifications@github.com
wrote:

Hi ! Is it easy to detect flakyness locally, e.g. would just rerunning the
suite couple of times locally give you intermittent failures ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#475 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABdWK4RW2pwMzVPuV4SS4Ham-0L_lw7xks5qzGslgaJpZM4KS8mR
.

@cyplo

This comment has been minimized.

Contributor

cyplo commented Oct 12, 2016

I'm interested in fixing it, will try to get a PR on the weekend possibly

killercup added a commit that referenced this issue Oct 12, 2016

Merge pull request #476 from cyplo/475_flaky_tests
Make database URL tests work in parallel.

Fix #475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment