Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor our test suite to not be reliant on specific values for ID #48
Comments
sgrif
added
the
good first issue
label
Dec 4, 2015
sgrif
changed the title from
Refactor our test suite to not be reliant on IDs
to
Refactor our test suite to not be reliant on specific values for ID
Dec 4, 2015
added a commit
to mcasper/diesel
that referenced
this issue
Dec 5, 2015
sgrif
closed this
in
#52
Dec 5, 2015
This comment has been minimized.
|
This issue still exists for doctests. |
sgrif
reopened this
Dec 5, 2015
This comment has been minimized.
|
There's still a lot of cases in our integration suite that #52 missed, too. |
sgrif
closed this
in
c49328b
Dec 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedDec 4, 2015
As we start to get into things like schema inference and migrations, which mean we want a persistent schema for our tests, we need to stop assuming the ids 1 and 2. Even though our tests will still run in isolated transactions, inserting rows in a transaction will bump the PK counter, regardless of whether or not the transaction is committed. This is fine, but we need to make sure our suite still passes.