/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel clobbers the macros from `diesel_codegen` #495

Closed
sgrif opened this Issue Nov 12, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.9
1 participant
@sgrif
@sgrif
Member

sgrif commented Nov 12, 2016

If you have

#[macro_use] extern crate diesel_codegen;
#[macro_use] extern crate diesel;

The macro definitions from diesel will completely clobber the ones from diesel codegen. We should probably just remove them (or rename them to impl_) at this point.

@sgrif sgrif referenced this issue Nov 12, 2016

Closed

Queryable, Insertable derivations not compiling on 1.14.0-nightly #492

@sgrif sgrif added this to the 0.9 milestone Dec 2, 2016

sgrif added a commit that referenced this issue Dec 6, 2016

@sgrif
Rename all bang derive macros to `impl_` 
Since all macro types share a single namespace now, even just declaring
these macros can cause problems even if they're never used.

Fixes #495.
be317e5

sgrif added a commit that referenced this issue Dec 6, 2016

@sgrif
Rename all bang derive macros to `impl_` 
Since all macro types share a single namespace now, even just declaring
these macros can cause problems even if they're never used.

Fixes #495.
e1df661

@sgrif sgrif referenced this issue Dec 6, 2016

Merged

Rename all bang derive macros to `impl_` #530

sgrif added a commit that referenced this issue Dec 6, 2016

@sgrif
Rename all bang derive macros to `impl_` 
Since all macro types share a single namespace now, even just declaring
these macros can cause problems even if they're never used.

Fixes #495.
7b21f27

sgrif added a commit that referenced this issue Dec 7, 2016

@sgrif
Rename all bang derive macros to `impl_` 
Since all macro types share a single namespace now, even just declaring
these macros can cause problems even if they're never used.

Fixes #495.
9d0df1b

@killercup killercup closed this in #530 Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment