/diesel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear which Row to import for FromSqlRow #535

Closed
jethrogb opened this Issue Dec 8, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jethrogb
@jethrogb
Contributor

jethrogb commented Dec 8, 2016 •
edited

If you want to implement FromSqlRow you need to name the Row type, but it's not a link in the docs and the only search result for Row (diesel::query_source::Queryable::Row) is not the right Row. The correct one seems to be diesel::row::Row.

sgrif added a commit that referenced this issue Dec 10, 2016

@sgrif
Document `diesel::row::Row` 
I had excluded this trait, as I intended for it to be mostly internal. I
still think this should be the case, but until I can provide a proper
blanket impl for `FromSqlRow`, this type will need to be public.

Fixes #535.
67bf22d

@sgrif sgrif referenced this issue Dec 10, 2016

Merged

Document `diesel::row::Row` #540

@killercup killercup closed this in #540 Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment