New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsChangeset works on a struct that only consists of primary keys on nightly #544

Closed
Drakulix opened this Issue Dec 13, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@Drakulix

Drakulix commented Dec 13, 2016

Deriving AsChangeset works with the proc-macro code-generation, but not via syntex/macro generation, if fields turns out to be empty. This happens if the struct contains nothing but primary keys (e.g. n:m relation tables).

Having an AsChangeset implementation on such a struct is of course not very useful and should most likely not be supported. I just noticed this inconsistency and think it should be fixed.

@Eijebong

This comment has been minimized.

Member

Eijebong commented Aug 9, 2017

This can be closed now that #1074 has landed.

@Eijebong Eijebong closed this Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment