Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRename `options` decorator #558
Comments
SergioBenitez
referenced this issue
Dec 30, 2016
Closed
Rocket's `options` and Diesel's `options` collide #83
This comment has been minimized.
|
FTR: Since macros 1.1 does not allow supplying parameters to the derive calls itself, we unfortunately need to deal with attribute namespacing. Diesel already does a bit of that with attributes like Luckily, as you note, this should not be a user-facing breaking change. The options attribute is only used in the macros |
killercup
added
good first issue
help wanted
labels
Jan 1, 2017
SergioBenitez
referenced this issue
Jan 3, 2017
Merged
Scope 'options' derive attributes under trait name. #565
This comment has been minimized.
|
BTW https://github.com/SergioBenitez/Rocket/blob/24805bbf16d25a21d6a926c86035ac905524c71c/scripts/test.sh#L80-L84 I super promise everything is fine now. Macros 1.1 fixed everything. |
SergioBenitez commentedDec 30, 2016
•
edited
Rocket uses
optionsas a decorator to declare an HTTPoptionsroute. Diesel uses it to declare options on schemas. This causes a collision when the two libraries are used together, resulting in a compilation error.It seems that the
optionsdecorator isn't used frequently by end-users in Diesel, whileoptionsin Rocket is one of the core decorators. Would you consider renamingoptionstoschema_optionsortable_options, or something else, so that the two can coexist before macro renaming is allowed?