Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd #[must_use] for warnings #609
Comments
killercup
added
good first issue
enhancement
help wanted
labels
Feb 3, 2017
This comment has been minimized.
|
I think this is fixed and good to close. |
This comment has been minimized.
|
Yup. Thanks! |
sgrif
closed this
Jul 19, 2017
This comment has been minimized.
TimNN
commented
Aug 5, 2017
•
|
Is this really fixed? The one PR linking this issue only mentions
(I also just spend some time trying to figure out why my |
This comment has been minimized.
|
Looks like we need an annotation on |
killercup
reopened this
Aug 5, 2017
This comment has been minimized.
|
I'm happy to put a PR up for this, if no one else is working on it |
This comment has been minimized.
|
@AndrewSpeed Feel free to take it. If there is any problem just ask here or (preferable) in our gitter channel. |
durango commentedFeb 3, 2017
•
edited
@sgrif:
I should add a #[must_use] on queries to prevent that mistake. Anyone mind opening an issue?@sgrif:
Making query.filter(name.like(user.name)); warn