Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema inference fails on array columns #65

Closed
sgrif opened this issue Dec 20, 2015 · 0 comments
Closed

Schema inference fails on array columns #65

sgrif opened this issue Dec 20, 2015 · 0 comments
Labels
bug
Milestone
0.4

Comments

@sgrif
Copy link
Member

sgrif commented Dec 20, 2015

This is due to the (very naive) type lookup that we do right now. The name of a string array in Postgres is _varchar. We need to be much more sophisticated.
sgrif added a commit that referenced this issue Dec 20, 2015
@sgrif
Ensure Vec<T> can be used in #[changeset_for]
ff2ea63 
Usually we implement all the various `AsExpression` for refs in the
`expression_impls!` macro. However, that macro doesn't work with generics,
and we forgot to handle `Vec<T>` (I think I figured the slice impl was
enough for some reason).

I tried to write a test for this change, but there are actually several
other bugs that prevent me from testing this properly. See #65 & #66.

Fixes #63.
@sgrif sgrif added this to the 0.4 milestone Dec 20, 2015
@sgrif sgrif added the bug label Dec 20, 2015
@sgrif sgrif closed this as completed in 57f6ffd Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@sgrif