New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final steps for MySQL support #653

Closed
sgrif opened this Issue Feb 9, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@sgrif
Member

sgrif commented Feb 9, 2017

We're close enough to being done and the remaining items are small/scattered enough I'd like to document them here in case anyone wants to take a swing at them.

  • Separate the PG/MySQL implementations of determine_column_type in codegen, fix the MySQL implementation to convert int -> integer, tinyint(1) -> bool, strip parens otherwise
  • Support MySQL in Diesel CLI
  • Enable MySQL on Travis
  • Remove the cfg flag from as many integration tests as possible that are currently not running for MySQL because they modify schema inside of a transaction
  • Implement timestamp helpers
  • Implement prepared statement caching
  • Support SystemTime and chrono
@sgrif

This comment has been minimized.

Member

sgrif commented Feb 9, 2017

#657 fixes item 1

@killercup killercup added the mysql label Feb 11, 2017

@sgrif

This comment has been minimized.

Member

sgrif commented Feb 15, 2017

Timestamp helpers can wait for now.

@sgrif sgrif closed this Feb 15, 2017

@diggyk

This comment has been minimized.

diggyk commented Mar 9, 2017

I know the helpers are not ready, but can timestamp or i64 be used at all at the moment? I'm having trouble with a struct that I want to use as Insertable:

#[derive(Insertable)]
| ^^^^^^^^^^ the trait diesel::Expression is not implemented for i64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment