Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up`diesel migration run` could use some UI improvement on errors #688
Comments
killercup
added
cli
good first issue
labels
Feb 12, 2017
This comment has been minimized.
|
What would the desired output for a failed migration run? Something like :
or
I'm just wondering what would be the best way and place to put the message. |
This comment has been minimized.
|
And I also saw #397 should this wait until the refactor is completed? |
This comment has been minimized.
|
I like the first one, but it might not be as good if the error message is very long. |
This comment has been minimized.
Dylan-DPC
commented
Jan 11, 2018
|
Hi. Interested in working on this |
sivakov512
referenced this issue
Jul 7, 2018
Closed
UI improvements for errors on migrations run and redo #1780
This comment has been minimized.
|
Hi! I make PR here. |
sivakov512
referenced this issue
Jul 19, 2018
Merged
UI improvements for errors on migrations run and redo #1790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedFeb 12, 2017
Two quick wins:
It needs to be a bit more obvious when a migration failed to run (literally we should just take up more lines). Additionally, it would be useful for us to give a path to the actual migration file that changed. Right now you just sort of know which one failed because the last line will before the error will be "
Running 873487534, but going from that to an actual path that you need to edit is a bit annoying.