New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`diesel migration run` could use some UI improvement on errors #688

Open
sgrif opened this Issue Feb 12, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@sgrif
Member

sgrif commented Feb 12, 2017

Two quick wins:

It needs to be a bit more obvious when a migration failed to run (literally we should just take up more lines). Additionally, it would be useful for us to give a path to the actual migration file that changed. Right now you just sort of know which one failed because the last line will before the error will be "Running 873487534, but going from that to an actual path that you need to edit is a bit annoying.

@ericho

This comment has been minimized.

Contributor

ericho commented Mar 8, 2017

What would the desired output for a failed migration run? Something like :

Running migration 20170308040245
Migration on /path/to/migration/up.sql failed with : unrecognized token: "{"

or

Running migration 20170308040245
Executing migration script /path/to/migration/up.sql
Failed with : unrecognized token: "{"

I'm just wondering what would be the best way and place to put the message.

@ericho

This comment has been minimized.

Contributor

ericho commented Mar 8, 2017

And I also saw #397 should this wait until the refactor is completed?

@Eijebong

This comment has been minimized.

Member

Eijebong commented Mar 8, 2017

I like the first one, but it might not be as good if the error message is very long.

@Dylan-DPC

This comment has been minimized.

Dylan-DPC commented Jan 11, 2018

Hi. Interested in working on this

@sivakov512

This comment has been minimized.

Contributor

sivakov512 commented Jul 9, 2018

Hi! I make PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment