New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spelling of Queriable trait name #71

Closed
sologub opened this Issue Dec 28, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@sologub

sologub commented Dec 28, 2015

The correct name would be Queryable.

@mfpiccolo

This comment has been minimized.

Collaborator

mfpiccolo commented Dec 28, 2015

It does look like Queryable is the preferred spelling. Google even gives a suggestion.
screen shot 2015-12-28 at 7 36 07 am
However, there are several references to Queriable as an acceptable alternate spelling.

@sologub

This comment has been minimized.

sologub commented Dec 28, 2015

I'd like to note that the Queryable name is used with a similar functionality in .NET LINQ, so the name difference may become a source of pain for .NET devs.
But I understand that this is a breaking change, so please feel free to just close this issue if you consider it unimportant.

@sgrif

This comment has been minimized.

Member

sgrif commented Dec 29, 2015

Yup, this appears to be correct. We can add a type alias as Queriable to ease migration. Feel free to open a PR renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment