Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify `LeftOuterJoinSource` and `InnerJoinSource` #759
Comments
This was referenced Jun 3, 2017
sgrif
closed this
in
#933
Jun 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sgrif commentedFeb 24, 2017
The main reason that these differ is because we need to change the SQL type of columns on the right side of the join. This required that these structs be separate types back in the pre-0.1 days when I added them, but we have sufficient information now to separate them. I'd like to have just a single
JoinSource<Left, Right, JoinType>.